Adding in NoMissingUnitTest linter rule#5294
Conversation
8441fa1 to
81aed85
Compare
|
@VaggelisD @georgesittas - alright, took my first swing at it if either of you want to take a look.
I did surface Let me know if you want me to change anything! |
2b486bc to
0c27875
Compare
georgesittas
left a comment
There was a problem hiding this comment.
Btw, let's make sure that we track calls to load_model_tests and refactor as needed. For example, in magics.py, I think we should be able to skip that call since we already have the loaded context which contains all tests. Another example is in lsp/context.py.
|
Thanks for addressing the comments @cmgoffena13. I'll take another look soon. |
|
@georgesittas - bumping this now that we're past the first round of holidays |
georgesittas
left a comment
There was a problem hiding this comment.
Thanks @cmgoffena13, I'll get this in and see if I can slightly refactor by removing / compacting some of the new context attributes.
I'm having trouble fleshing out the test due to the path having to point to the example project. Since I have to trigger the pytest from the root it is trying to find the /tests directory in the root rather than the example project root. Any help on resolving the path issue would be appreciated so I can finish the test. (EDIT: Figured out how to switch the contexts, let me know if there's anything that needs adjustment!)