Fix!: depend on all attributes of dbt model when passed to a macro#5269
Merged
georgesittas merged 6 commits intomainfrom Sep 4, 2025
Merged
Fix!: depend on all attributes of dbt model when passed to a macro#5269georgesittas merged 6 commits intomainfrom
model when passed to a macro#5269georgesittas merged 6 commits intomainfrom
Conversation
fd4ec21 to
a27ed55
Compare
erindru
reviewed
Sep 1, 2025
izeigerman
reviewed
Sep 2, 2025
izeigerman
reviewed
Sep 2, 2025
izeigerman
reviewed
Sep 2, 2025
izeigerman
reviewed
Sep 2, 2025
izeigerman
reviewed
Sep 2, 2025
f8bd60b to
3384035
Compare
3384035 to
f1e03a8
Compare
f1e03a8 to
8919c48
Compare
izeigerman
reviewed
Sep 3, 2025
izeigerman
reviewed
Sep 3, 2025
izeigerman
reviewed
Sep 3, 2025
izeigerman
reviewed
Sep 3, 2025
6112d57 to
534aadd
Compare
534aadd to
0c18299
Compare
izeigerman
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we pass the dbt
modelkeyword to a macro (e.g.,{{ foo(model) }}), we can't easily track the attributes that are actually used, because the argument may be aliased and hence tracking actual uses ofmodelrequires a proper data flow analysis.This PR handles this case by conservatively including all of
model's supported attributes if a "standalone" reference is detected. We decided to excluderaw_codeto reduce the snapshot's payload size, since we can access it through theJinjaQuerynode directly.P.S.: may need to revisit before merging to see if we can migrate this properly.