-
Notifications
You must be signed in to change notification settings - Fork 1.2k
1 #858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
1 #858
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cc3223c
feat(歌词): 增加自适应歌词字体大小模式
kazukokawagawa 4573cd9
修QRC歌词
kazukokawagawa f976466
refactor(歌词样式): 将字体大小计算逻辑提取为工具函数
kazukokawagawa 740f73c
Merge pull request #852 from imsyy/dev-style
imsyy 3829b07
🦄 refactor: 优化在任务栏歌词窗口中的开发者工具打开
apoint123 67c2221
Merge pull request #856 from apoint123/refactor/optimize-devtools-in-…
imsyy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
|
|
||
| /** | ||
| * 获取自适应或固定像素的字体大小 | ||
| * @param size 字体大小数值 | ||
| * @param mode 字体大小模式 ('adaptive' | 'fixed') | ||
| * @returns CSS font-size 字符串 | ||
| */ | ||
| export const getFontSize = (size: number, mode: string) => { | ||
| if (mode === "adaptive") { | ||
| return `calc(${size} / 1080 * 100vh)`; | ||
| } | ||
| return `${size}px`; | ||
| }; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better type safety, it's recommended to use a more specific type for the
modeparameter instead ofstring. Based on its usage withsettingStore.lyricFontSizeMode, the type should be'fixed' | 'adaptive'.