Skip to content
This repository was archived by the owner on Jan 11, 2026. It is now read-only.

[REFACTOR] 회원 및 인증 도메인 유즈케이스별 구조 개선#14

Merged
msk226 merged 9 commits into
developfrom
SPOT-281/refactor
May 17, 2025
Merged

[REFACTOR] 회원 및 인증 도메인 유즈케이스별 구조 개선#14
msk226 merged 9 commits into
developfrom
SPOT-281/refactor

Conversation

@msk226
Copy link
Copy Markdown
Member

@msk226 msk226 commented May 15, 2025

#️⃣ 연관된 이슈


🔎 작업 내용

  • 회원 및 인증 관련 기능 책임 명확히 분리
  • 레거시 코드는 @Deprecated 애노테이션 추가 및 /legacy 패키지로 이동
  • 회원 도메인 내 인증 관련 책임 분리 (소셜 로그인, 토큰 발급, 회원 정보 수정 등)
  • 카카오 소셜 로그인 책임 분리 완료, 구글 로그인은 작업 예정
  • RSA 관련 인증 유틸은 Auth 도메인으로 이동

📷 스크린샷 (선택)

작업한 결과물에 대한 간단한 스크린샷을 올려주세요.


💬리뷰 요구사항 (선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요.

  • 이번 PR도 코드 수정은 없고, 패키지 이동만 있기 때문에 IDE에서 확인 하시면 더 편하게 보실 수 있습니다!

@msk226 msk226 requested review from FromKyoung, Copilot and dvlp-sy May 15, 2025 06:18
@msk226 msk226 self-assigned this May 15, 2025
@msk226 msk226 added the ♻️ refactor Code Refactoring label May 15, 2025
@msk226 msk226 linked an issue May 15, 2025 that may be closed by this pull request
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the authentication and member-related modules by splitting responsibilities into distinct classes and packages, and by marking legacy code as deprecated. Key changes include package renaming for authentication classes, migration of RSA and verification code logic to the auth domain, and the introduction of refactored implementations for Kakao and JWT authentication.

Reviewed Changes

Copilot reviewed 53 out of 53 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/main/java/com/example/spot/auth/presentation/controller/legacy/AuthController.java Updated package/import paths and added deprecation to legacy controller.
src/main/java/com/example/spot/auth/infrastructure/kakao/KakaoOAuthClient.java Applied package renaming and updated import paths for Kakao OAuth support.
src/main/java/com/example/spot/auth/domain/* Updated various domain classes to the auth package.
src/main/java/com/example/spot/auth/application/refactor/* Introduced refactored implementations for authentication services supporting Kakao and JWT.
src/main/java/com/example/spot/auth/application/legacy/* Marked legacy authentication services as deprecated and updated package/imports accordingly.


// 응답에서 액세스 토큰을 파싱
KaKaoOAuthToken.KaKaoOAuthTokenDTO oAuthToken = client.getAccessToken(accessTokenResponse);
System.out.println(oAuthToken.getAccess_token());
Copy link

Copilot AI May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using System.out.println in production code; please use a proper logging mechanism (e.g., log.debug or log.info) to maintain consistency with the rest of the code.

Suggested change
System.out.println(oAuthToken.getAccess_token());
log.debug(oAuthToken.getAccess_token());

Copilot uses AI. Check for mistakes.
@msk226 msk226 changed the title [REFACTOR] 회원 서비스 로직 유즈케이스별로 클래스 분리 [REFACTOR] 회원 및 인증 도메인 유즈케이스별 구조 개선 May 15, 2025
Copy link
Copy Markdown
Collaborator

@dvlp-sy dvlp-sy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인이 늦어서 죄송합니다! 고생하셨어요 👍🏻👍🏻

@msk226 msk226 merged commit 67b833a into develop May 17, 2025
1 check passed
@msk226 msk226 deleted the SPOT-281/refactor branch May 17, 2025 05:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

♻️ refactor Code Refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REFACTOR] 회원 서비스 로직 유즈케이스별로 클래스 분리

3 participants