Add fallback to merge samples without stacking in amdirt viewer#184
Open
Add fallback to merge samples without stacking in amdirt viewer#184
Conversation
jfy133
reviewed
Mar 10, 2026
Member
jfy133
left a comment
There was a problem hiding this comment.
During testing I hit the following error:
Select ancientsinglegneome-hostassociated table
- Select all Neukamm2020 samples, and validate samples
- Select all Neukam2020 libraries (note: this DOES show all associated libraries), validate libraries
- I get the following error after pressing validate libraries, and the bibtext button doesn't load
All working buttons downloaded stuff as expected however!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue on AncientMetagenomeDir. In brief, if a sample has more than one sample accession number (SRS or ERS code) in the
sampletable, we typically split this list of comma-separated sample accession numbers before searching for them in thelibrarytable.However, there are a few samples for which all sequencing data in the
librarytable has been tagged with the same comma-separated list of sample accession numbers. For these, splitting the comma-separated numbers destroys the link to the data in thelibrarytable.To consider the latter case, I implemented a fallback option that when after splitting the comma-separated list no library information has been found, then it is tested whether not-splitting the sample accession numbers will yield library information.