Skip to content

Add fallback to merge samples without stacking in amdirt viewer#184

Open
alexhbnr wants to merge 1 commit intomasterfrom
viewer-multiple-accessioncodes
Open

Add fallback to merge samples without stacking in amdirt viewer#184
alexhbnr wants to merge 1 commit intomasterfrom
viewer-multiple-accessioncodes

Conversation

@alexhbnr
Copy link
Copy Markdown
Collaborator

This PR addresses the issue on AncientMetagenomeDir. In brief, if a sample has more than one sample accession number (SRS or ERS code) in the sample table, we typically split this list of comma-separated sample accession numbers before searching for them in the library table.

However, there are a few samples for which all sequencing data in the library table has been tagged with the same comma-separated list of sample accession numbers. For these, splitting the comma-separated numbers destroys the link to the data in the library table.

To consider the latter case, I implemented a fallback option that when after splitting the comma-separated list no library information has been found, then it is tested whether not-splitting the sample accession numbers will yield library information.

@alexhbnr alexhbnr requested a review from jfy133 March 10, 2026 13:05
Copy link
Copy Markdown
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During testing I hit the following error:

Select ancientsinglegneome-hostassociated table

  1. Select all Neukamm2020 samples, and validate samples
  2. Select all Neukam2020 libraries (note: this DOES show all associated libraries), validate libraries
  3. I get the following error after pressing validate libraries, and the bibtext button doesn't load
image

All working buttons downloaded stuff as expected however!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants