fix: harden sanitize-html xmp handling (GHSA-rpr9-rxv7-x643)#24
Merged
Conversation
…-x643 by forcing disallowed xmp content into nonTextTags unless xmp is explicitly allowed. That change is in lib/allowlist.js. It covers both the built-in default policy and any custom policy loaded through ALLOWLIST_FILE. Also added regressions in tests/allowlist.test.js and tests/validation.test.js for the advisory’s xmp PoC path.
scops
approved these changes
May 14, 2026
Collaborator
|
There is already patched version 2.17.4, we need to update lockfile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xmpcontent intononTextTagsunlessxmpis explicitly allowed, closing the GHSA-rpr9-rxv7-x643 bypass path.ALLOWLIST_FILE(lib/allowlist.js).xmpPoC intests/allowlist.test.jsandtests/validation.test.js.Test plan
npm testpasses locally and in CI