Conversation
jere8184
suggested changes
Jan 22, 2025
jere8184
reviewed
Jan 23, 2025
jere8184
reviewed
Jan 23, 2025
Co-authored-by: jere8184 <jeremiahmorgan.bham@outlook.com>
jere8184
suggested changes
Jan 24, 2025
heinezen
requested changes
Jan 25, 2025
Member
heinezen
left a comment
heinezen
left a comment
There was a problem hiding this comment.
Looks pretty good so far.
In addition to the fixes to the comments I made, you should also add unit tests for stamping and unstamping the cost field in tests.cpp.
Co-authored-by: Christoph Heine <6852422+heinezen@users.noreply.github.com>
Co-authored-by: Christoph Heine <6852422+heinezen@users.noreply.github.com>
heinezen
added
nice new thing ☺
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1676.