Fix symbol export/import on windows#335
Merged
lapinozz merged 4 commits intoSFML:masterfrom Apr 4, 2026
Merged
Conversation
ChrisThrasher
requested changes
Feb 1, 2026
eXpl0it3r
reviewed
Feb 18, 2026
eXpl0it3r
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the DLLs macros so the shared build would work with MSVC
IMGUI_SFML_SHARED_LIB should be defined public in shared build, so that when you link against the lib you get dll import
IMGUI_SFML_EXPORTS is defined private so that the lib itself compiles with the dll export
IMGUI_API and IMGUI_SFML_API should both be the same since the source for both is compiled directly into the lib so I simplified the code and defined IMGUI_API as IMGUI_SFML_API