Issue 5525/implement split btn for resource#5563
Open
vushu wants to merge 2 commits into
Open
Conversation
added 2 commits
April 30, 2026 13:41
Tiggles
reviewed
May 18, 2026
| const menuItems: VmActionItem[] = rest.map((childOp, idx) => ({ | ||
| key: idx.toString(), | ||
| value: getText(childOp), | ||
| icon: childOp.icon, |
Contributor
There was a problem hiding this comment.
childOp.icon needs a fallback value here, otherwise is a compilation error.
Tiggles
reviewed
May 18, 2026
| target.innerHTML = ""; | ||
| for (const op of operations) { | ||
| target.append(renderOperation(op)); | ||
| if (op.buttonStyle === "split") { |
Contributor
There was a problem hiding this comment.
buttonStyle exists for OperationGroup and not Operation, so this check can fix this:
Suggested change
| if (op.buttonStyle === "split") { | |
| if ("buttonStyle" in op && op.buttonStyle === "split") { |
Contributor
|
The right side of the splitButton should be the same color as the left, and the icon color in the dropdown should use the same color scheme in the filters, that take light/dark theme into account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added vm split to resource browser.