Merged
Conversation
Collaborator
|
Can we rename it to something like job audit log? To differentiate it from the other audit log that the IM also has (for requests, it is in the |
Contributor
Author
|
I have renamed it job audit log as suggested. |
Contributor
Author
|
Updated to walk through dirs and consider child folders, since each job has it's own folder inside audit that is the jobs id. |
DanThrane
reviewed
Mar 13, 2026
| go func() { | ||
| cleanupLogs(retentionDays) // run once at startup | ||
|
|
||
| ticker := time.NewTicker(24 * time.Hour) |
Collaborator
There was a problem hiding this comment.
I think we need to increase the frequency that this runs. Mostly to account for potential restarts of the service. Every 4 hours should be fine.
DanThrane
requested changes
Mar 16, 2026
| "ucloud.dk/shared/pkg/log" | ||
| ) | ||
|
|
||
| var jobAuditLogFolder = "/mnt/storage/audit" |
Collaborator
There was a problem hiding this comment.
Not guaranteed to be the correct mount-point. See the MountPoint configuration option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added rentention cleanup logic for audit logs
This PR is based on https://github.com/SDU-eScience/UCloud/compare/issue-5413