Refactor SyncManager to remove stale queue and ready signal useEffects#46
Merged
Refactor SyncManager to remove stale queue and ready signal useEffects#46
Conversation
- Create socketRegistry to make socket accessible outside React components - Add syncMiddleware that emits docUpdate when markStale action is dispatched - Move socket ready signal directly into handleFullSync completion using socketRef - Remove two reactive useEffects that were causing cascading state updates This makes the sync flow more explicit: docs are emitted immediately when marked stale (if connected), and the ready signal is emitted as part of sync completion rather than as a reactive cascade. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This completes the fifth priority from the useEffect elimination plan.
Test plan
🤖 Generated with Claude Code