Refactor update trigger from useEffect to direct event handler#45
Merged
Conversation
Move the service worker update trigger (postMessage SKIP_WAITING) from a reactive useEffect chain to a direct call in the click handler. This eliminates the userReadyToUpdate state and the cascading effect pattern. - Add registration.ts module to store ServiceWorkerRegistration outside React - Call triggerUpdate() directly in UpdatePanel and UpdateMenuItem click handlers - Remove userReadyToUpdate state from updateSlice - Update CLAUDE.md to clarify yarn test already includes --run Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
postMessage SKIP_WAITING) from a reactive useEffect chain to direct calls in click handlersregistration.tsmodule to store ServiceWorkerRegistration outside React (same pattern as PouchDB handle)userReadyToUpdatestate from Redux slice - no longer neededyarn testalready includes--runTest plan
🤖 Generated with Claude Code