Refactor debug filter from useEffect to Redux middleware#44
Merged
Conversation
Move debug filter initialization and sync logic out of DebugManager's useEffect and into Redux middleware. This eliminates the anti-pattern of dispatching state updates in effects that should be computed at init time. - Initialize debug state from localStorage at store creation - Use debugMiddleware to sync state changes to localStorage/debugModule - Remove DebugManager component (no longer needed) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Empty string "" is falsy but was not handled by the middleware - only null was explicitly checked. Now treat any falsy value as a clear. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
debugMiddlewareto sync state changes to localStorage and debugModuleDebugManagercomponent entirely (no longer needed)This eliminates the anti-pattern of dispatching state updates in effects for derived state that should be computed at init time.
Test plan
🤖 Generated with Claude Code