Skip to content

Conversation

@jimlo7760
Copy link
Collaborator

@jimlo7760 jimlo7760 commented May 2, 2025

Steps of sanity checks:

  1. Triggers on Pull Requests: Activates whenever someone creates or updates a PR targeting the main branch that contains changes to Python files.
  2. Checks Critical Parameters: Specifically looks for changes to:
  • Number of epochs (--epochs)

  • Training frame range (--trainFrameFirst and --trainFrameLast)

  • Validation frame range (--validationFrameFirst and --validationFrameLast)

  1. Compares Values: The workflow extracts these parameter default values from both the PR code and the main branch code, then compares them.
  2. Fails if Parameters Changed: If there are any differences in these critical training parameters, the workflow will fail with a clear message indicating which parameters changed and their values.

@jimlo7760 jimlo7760 requested a review from cwsmith May 2, 2025 18:19
Copy link
Contributor

@cwsmith cwsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

@cwsmith cwsmith merged commit c380ee5 into main May 19, 2025
@cwsmith cwsmith deleted the luy/workflow branch May 19, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants