Add support for Windows builds via vcpkg #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't rely on nonstandard extensions (such as M_PI) - Don't rely on transitive includes for some standard types - Switch to C++20 so we can use std::numbers
from 6b575523ce838fc13517d1a8021ce4883efc29c1
These come from a external project and shouldn't be re-formatted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
spackis not available on Windows, this PR addsvcpkgas a secondary package manager as well.It also includes some changes to the code to make it more portable across different operating systems (e.g. not relying on some transitive #includes or non-standard math defines)