Reimplement script discovery via native globwalk#84
Conversation
* Replace the `glob` crate with `globwalk = "0.9.1"` in Cargo.toml. * Rewrite `resolve_explicit_scripts` to use `GlobWalkerBuilder::from_patterns` to process explicit inclusion/exclusion (`!`) natively without manual filtering. * Rewrite `resolve_fallback_scripts` to use `GlobWalkerBuilder::from_patterns` with depth 1. * Change return types of discovery functions to `anyhow::Result<Vec<camino::Utf8PathBuf>>`. * Adapt call sites in `build_project` pipeline. Co-authored-by: MiguelRodo <23501332+MiguelRodo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Reimplement script discovery using native globwalk to fix glob issues and improve Unicode path handling.
PR created automatically by Jules for task 17009418343105555883 started by @MiguelRodo