match sub_8058AE0#16
Merged
Merged
Conversation
JaceCear
requested changes
Jun 26, 2026
| // thanks idefix helping in the matching | ||
| bool32 sub_8058AE0(Aotento *enemy) | ||
| { | ||
| s32 q = Q(64); // a variable just for holding Q(64)? interesting... |
Contributor
There was a problem hiding this comment.
You can remove that comment, doesn't help anyone.
And maybe the variable could be called qJumpHeight or something?
Contributor
Author
There was a problem hiding this comment.
yeah, i gotta stop with this weird habit of mines of commenting about either random or obvious stuff lol
|
|
||
| // (94.17%) https://decomp.me/scratch/nMoLp | ||
| NONMATCH("asm/non_matching/game/enemies/aotento__sub_8058AE0.inc", bool32 sub_8058AE0(Aotento *enemy)) | ||
| // thanks idefix helping in the matching |
Contributor
There was a problem hiding this comment.
I think it's clearer to just add the co-author line when merging (I can do that if you'd like)!
Contributor
There was a problem hiding this comment.
And in the future, best add it when pushing a commit someone helped out on, then it automatically gets added for the Squash-and-merge!
Contributor
Author
There was a problem hiding this comment.
i mean, if you don't mind it
JaceCear
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yeah, i don't think there's much to say about this one
once again, though, thanks for the help, @idefix02!