fix: add keyboard focus-visible indicator to chip component#1306
Merged
SAPTARSHI-coder merged 2 commits intoJun 4, 2026
Merged
Conversation
Contributor
📊 CSS Bundle Size BenchmarkNo change in CSS bundle size. ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #1289. Resolves keyboard focus styling of the
.ease-chipcheckbox labels.Currently, the native checkbox inside
.ease-chip-groupis visually hidden (opacity 0, dimensions 0, position absolute, pointer-events none). Because the label acts as the visual representation of the interactive checkbox chip, keyboard users navigating with Tab do not receive any visual feedback indicating which chip has current focus.This PR adds a
:focus-visibleoutline indicator on the adjacent.ease-chipsibling when the hidden checkbox input receives keyboard focus, ensuring full WCAG 2.1 AA keyboard focus visibility requirements are met.Type of Change
Submission Checklist
submissions/examples/your-feature-name/demo.html— self-contained, opens in browser with no serverstyle.css— raw CSS for the proposed featureREADME.md— what it does, how to use it, why it fits EaseMotion CSScore/components/(N/A - Core bug fix in components/chip.css)Feature Description
What does this add?
Adds a visible outline focus ring around interactive chips when navigated via keyboard.
How does a developer use it?
Why does it fit EaseMotion CSS?
It improves user accessibility and keyboard navigation UX on interactive components while preserving the clean, modern look of the custom chips.
Demo
components/chip-demo.htmllocally)Browser Testing
Notes for Maintainer
Tested locally with all linters (
npm run lint,npm run lint:duplicates) and tests passing successfully. Visual focus ring verified on Chromium during keyboard tab navigation.