Skip to content

fix(core): remove duplicate --ease-color-secondary variable block in :root#1211

Merged
SAPTARSHI-coder merged 1 commit into
SAPTARSHI-coder:mainfrom
ionfwsrijan:fix-1206-duplicate-secondary-color
Jun 4, 2026
Merged

fix(core): remove duplicate --ease-color-secondary variable block in :root#1211
SAPTARSHI-coder merged 1 commit into
SAPTARSHI-coder:mainfrom
ionfwsrijan:fix-1206-duplicate-secondary-color

Conversation

@ionfwsrijan
Copy link
Copy Markdown
Contributor

@ionfwsrijan ionfwsrijan commented Jun 4, 2026

Description

The entire secondary color block (--ease-color-secondary, --ease-color-secondary-light, --ease-color-secondary-dark) is defined twice with identical values in :root. The first occurrence at lines 26–28 is dead code since CSS uses last-definition-wins.

Fix

Removed the duplicate block at lines 38–40.

Changes

  • core/variables.css:38-40 — removed duplicate --ease-color-secondary variable definitions

Closes #1206

@ionfwsrijan
fix(core): remove duplicate --ease-color-secondary variable block in …
5cc9cfe 
…:root

The secondary color block was defined twice with identical values (lines 26-28
and 38-40). Since CSS uses last-definition-wins, the first block was dead code.
Removed the duplicate at lines 38-40.

Closes SAPTARSHI-coder#1206
@github-actions github-actions Bot added the core label Jun 4, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

📊 CSS Bundle Size Benchmark

This PR changes the size of easemotion.min.css.

Metric Base Branch This PR Difference
Raw 39.16 KB 39.06 KB 📉 -0.10 KB
Gzip 7.16 KB 7.16 KB 📉 -0.00 KB
Brotli 6.19 KB 6.19 KB 📈 +0.01 KB

@ionfwsrijan
Copy link
Copy Markdown
Contributor Author

ionfwsrijan commented Jun 4, 2026

@SAPTARSHI-coder You may review and merge

@SAPTARSHI-coder SAPTARSHI-coder added accepted Contribution approved for integration into EaseMotion CSS animation Animation effects, hover interactions, motion ideas, transitions component New UI components (buttons, cards, modals, tooltips, badges) enhancement New feature or request good first issue Good for newcomers GSSoC-26 Official GSSoC 2026 issue gssoc:approved Approved for GSSoC contributions integrated Successfully merged and included in the framework level:intermediate Requires moderate project understanding type:feature New functionality or enhancement labels Jun 4, 2026
@ionfwsrijan
Copy link
Copy Markdown
Contributor Author

ionfwsrijan commented Jun 4, 2026

@SAPTARSHI-coder Can you please merge this now?

@SAPTARSHI-coder SAPTARSHI-coder merged commit f164500 into SAPTARSHI-coder:main Jun 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SAPTARSHI-coder SAPTARSHI-coder Awaiting requested review from SAPTARSHI-coder SAPTARSHI-coder is a code owner

Assignees

@ionfwsrijan ionfwsrijan

@SAPTARSHI-coder SAPTARSHI-coder

Labels

accepted Contribution approved for integration into EaseMotion CSS animation Animation effects, hover interactions, motion ideas, transitions component New UI components (buttons, cards, modals, tooltips, badges) core enhancement New feature or request good first issue Good for newcomers gssoc:approved Approved for GSSoC contributions GSSoC-26 Official GSSoC 2026 issue integrated Successfully merged and included in the framework level:intermediate Requires moderate project understanding type:feature New functionality or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Duplicate --ease-color-secondary Variable Block in :root

2 participants

@ionfwsrijan @SAPTARSHI-coder