fix(components): use per-variant --ease-btn-glow instead of hardcoded --ease-glow-primary#1210
Merged
SAPTARSHI-coder merged 2 commits intoJun 4, 2026
Conversation
… --ease-glow-primary Each button variant sets --ease-btn-glow to its own glow color, but .ease-btn-hover hardcoded var(--ease-glow-primary). With this fix, the glow defers to var(--ease-btn-glow) with var(--ease-glow-primary) as fallback. Closes SAPTARSHI-coder#1205
Contributor
📊 CSS Bundle Size BenchmarkThis PR changes the size of
|
Contributor
Author
|
@SAPTARSHI-coder You may review and merge |
SAPTARSHI-coder
added
accepted
Contributor
Author
|
@SAPTARSHI-coder Can you please merge this now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Each button variant sets
--ease-btn-glowto its own glow color (--ease-glow-success,--ease-glow-danger, etc.), but the.ease-btn-hoverclass hardcodesvar(--ease-glow-primary)instead of using the variant's custom property. Success, danger, outline, and ghost buttons all glow purple instead of their respective colors.Fix
Changed the hardcoded
var(--ease-glow-primary)tovar(--ease-btn-glow, var(--ease-glow-primary))so per-variant glow colors take effect with the primary glow as fallback.Changes
components/buttons.css:222— use--ease-btn-glowwith--ease-glow-primaryfallbackCloses #1205