Skip to content

fix(core): add missing closing brace for .ease-shimmer-sweep block#1209

Merged
SAPTARSHI-coder merged 1 commit into
SAPTARSHI-coder:mainfrom
ionfwsrijan:fix-1204-missing-closing-brace
Jun 4, 2026
Merged

fix(core): add missing closing brace for .ease-shimmer-sweep block#1209
SAPTARSHI-coder merged 1 commit into
SAPTARSHI-coder:mainfrom
ionfwsrijan:fix-1204-missing-closing-brace

Conversation

@ionfwsrijan
Copy link
Copy Markdown
Contributor

@ionfwsrijan ionfwsrijan commented Jun 4, 2026

Description

The .ease-shimmer-sweep class declaration block is missing its closing } at line 725. This causes the .ease-squish-button:hover, .ease-squish-button:focus-visible, and .ease-squish-button:active selectors on lines 727–731 to be parsed inside the broken block, making the squish-button hover animation never apply.

Fix

Added the missing closing } after the animation declaration in .ease-shimmer-sweep.

Changes

  • core/animations.css:726 — added } to close the .ease-shimmer-sweep block

Closes #1204

@ionfwsrijan
fix(core): add missing closing brace for .ease-shimmer-sweep block
600aa92 
The .ease-shimmer-sweep rule block was missing its closing '}' on line 726,
which caused .ease-squish-button hover/focus-visible/active selectors to be
parsed inside the broken block, preventing squish-button animations from applying.

Closes SAPTARSHI-coder#1204
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

📊 CSS Bundle Size Benchmark

This PR changes the size of easemotion.min.css.

Metric Base Branch This PR Difference
Raw 39.16 KB 39.16 KB ➖ 0.00 KB
Gzip 7.16 KB 7.16 KB 📉 -0.00 KB
Brotli 6.19 KB 6.19 KB 📈 +0.00 KB

@github-actions github-actions Bot added the core label Jun 4, 2026
@ionfwsrijan
Copy link
Copy Markdown
Contributor Author

ionfwsrijan commented Jun 4, 2026

@SAPTARSHI-coder You may review and merge

@SAPTARSHI-coder SAPTARSHI-coder added accepted Contribution approved for integration into EaseMotion CSS animation Animation effects, hover interactions, motion ideas, transitions component New UI components (buttons, cards, modals, tooltips, badges) enhancement New feature or request good first issue Good for newcomers GSSoC-26 Official GSSoC 2026 issue gssoc:approved Approved for GSSoC contributions integrated Successfully merged and included in the framework level:intermediate Requires moderate project understanding type:feature New functionality or enhancement labels Jun 4, 2026
@ionfwsrijan
Copy link
Copy Markdown
Contributor Author

ionfwsrijan commented Jun 4, 2026

@SAPTARSHI-coder Can you please merge this now?

@SAPTARSHI-coder SAPTARSHI-coder added bug Something isn't working level:beginner Suitable for first-time contributors and removed enhancement New feature or request animation Animation effects, hover interactions, motion ideas, transitions component New UI components (buttons, cards, modals, tooltips, badges) level:intermediate Requires moderate project understanding type:feature New functionality or enhancement core labels Jun 4, 2026
@SAPTARSHI-coder SAPTARSHI-coder merged commit 24e670b into SAPTARSHI-coder:main Jun 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SAPTARSHI-coder SAPTARSHI-coder Awaiting requested review from SAPTARSHI-coder SAPTARSHI-coder is a code owner

Assignees

@ionfwsrijan ionfwsrijan

@SAPTARSHI-coder SAPTARSHI-coder

Labels

accepted Contribution approved for integration into EaseMotion CSS bug Something isn't working good first issue Good for newcomers gssoc:approved Approved for GSSoC contributions GSSoC-26 Official GSSoC 2026 issue integrated Successfully merged and included in the framework level:beginner Suitable for first-time contributors

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing Closing Brace Breaks .ease-shimmer-sweep and Orphans .ease-squish-button Selectors

2 participants

@ionfwsrijan @SAPTARSHI-coder