refactor: address minor review comments on Standalone Components PR #20793#21130
Merged
refactor: address minor review comments on Standalone Components PR #20793#21130
Conversation
…ed '@component's in .spec.ts files
…estbed.configureTestingModule()` to fix broken tests, which relied on transitively importing `I18nTestingModule` via '@component's imports (from where we've removed `I18nTestingModule` in previous commit)
pawelfras
previously approved these changes
Feb 23, 2026
Contributor
pawelfras
left a comment
pawelfras
left a comment
There was a problem hiding this comment.
Please change the target branch to develop
pawelfras
previously approved these changes
Feb 23, 2026
pawelfras
approved these changes
Feb 24, 2026
spartacus
|
||||||||||||||||||||||||||||||
| Project |
spartacus
|
| Branch Review |
feature/CXSPA-11889-v1
|
| Run status |
|
| Run duration | 11m 02s |
| Commit |
|
| Committer | Krzysztof Platis |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
101
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses PR comments from #20793 that were postponed.
For easier review, see individual commits.
fixes https://jira.tools.sap/browse/CXSPA-11889