Skip to content

refactor: remove unused schematics utils#21089

Merged
Platonn merged 4 commits intodevelopfrom
feature/CXSPA-11980
Feb 18, 2026
Merged

refactor: remove unused schematics utils#21089
Platonn merged 4 commits intodevelopfrom
feature/CXSPA-11980

Conversation

@Platonn
Copy link
Copy Markdown
Contributor

@Platonn Platonn commented Jan 28, 2026

After removing old major migrations code in #21046, some legacy utils remained unused. This PR removes unused utils:

  • getDynamicallyImportedLocalSourceFile
  • renameIdentifierNode
  • getLineFromTSFile
  • isImportedFromSpartacusCoreLib
  • loadEsmModule
  • addImport
  • createImportChange
  • addToModuleDeclarations
  • addToModuleImportsAndCommitChanges
  • getAppModule
  • addModuleDeclaration
  • buildDefaultPath

Note: those utils operate on typescript or Change objects, but new suggested approach is to use ts-morph due to its DX friendly api

fixes https://jira.tools.sap/browse/CXSPA-11980

@Platonn Platonn requested a review from a team as a code owner January 28, 2026 14:08
@github-actions github-actions Bot marked this pull request as draft January 28, 2026 14:09
pawelfras
pawelfras previously approved these changes Feb 9, 2026
Copy link
Copy Markdown
Contributor

@pawelfras pawelfras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming customers are not using utils from our schematics (they shouldn't)

@Platonn Platonn marked this pull request as ready for review February 9, 2026 13:58
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 9, 2026

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions Bot marked this pull request as draft February 9, 2026 13:58
@Platonn Platonn changed the base branch from release/221121.7.x to develop February 11, 2026 14:44
@Platonn Platonn dismissed pawelfras’s stale review February 11, 2026 14:44

The base branch was changed.

@pawelfras pawelfras marked this pull request as ready for review February 18, 2026 14:20
@github-actions github-actions Bot marked this pull request as draft February 18, 2026 17:09
@Platonn Platonn marked this pull request as ready for review February 18, 2026 17:10
@Platonn Platonn merged commit f4c9819 into develop Feb 18, 2026
24 checks passed
@Platonn Platonn deleted the feature/CXSPA-11980 branch February 18, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants