Skip to content

fix: fix pages title (breadcrumb section) on languge switch#21032

Merged
uroslates merged 19 commits intodevelopfrom
feature/CXSPA-10923-login-page-translations-develop-next-major
Feb 19, 2026
Merged

fix: fix pages title (breadcrumb section) on languge switch#21032
uroslates merged 19 commits intodevelopfrom
feature/CXSPA-10923-login-page-translations-develop-next-major

Conversation

@uroslates
Copy link
Copy Markdown
Contributor

@uroslates uroslates commented Jan 19, 2026

@uroslates uroslates requested a review from a team as a code owner January 19, 2026 08:21
@github-actions github-actions Bot marked this pull request as draft January 19, 2026 08:29
@uroslates uroslates marked this pull request as ready for review January 19, 2026 08:38
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 19, 2026

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions Bot marked this pull request as draft January 19, 2026 08:45
@uroslates uroslates marked this pull request as ready for review January 19, 2026 08:46
@cypress
Copy link
Copy Markdown

cypress Bot commented Jan 19, 2026 •
edited
Loading

spartacus    Run #51906

Run Properties:  status check passed Passed #51906  •  git commit f8f5f58ed5 ℹ️: Merge 8c3218e5b6cd08efaad77e06b3674f938fd1e34b into 126bfe64cdd6f88f89a508405acd...
Project spartacus
Branch Review feature/CXSPA-10923-login-page-translations-develop-next-major
Run status status check passed Passed #51906
Run duration 03m 40s
Commit git commit f8f5f58ed5 ℹ️: Merge 8c3218e5b6cd08efaad77e06b3674f938fd1e34b into 126bfe64cdd6f88f89a508405acd...
Committer Uros Lates
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 101
View all changes introduced in this branch ↗︎

@github-actions github-actions Bot marked this pull request as draft January 19, 2026 13:17
@uroslates uroslates marked this pull request as ready for review January 19, 2026 13:23
@github-actions github-actions Bot marked this pull request as draft January 19, 2026 13:23
@sap-email-compliance
Copy link
Copy Markdown

sap-email-compliance Bot commented Jan 19, 2026

SAP employees are expected to use their SAP-email address for commits related to their work. Our compliance check has detected usage of an email other than a SAP one by a SAP employee. Please update your pull request accordingly.

If you think this is wrong or need any assistance, please contact ospo@sap.com.

@uroslates uroslates marked this pull request as ready for review January 19, 2026 13:23
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 19, 2026

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@github-actions github-actions Bot marked this pull request as draft January 20, 2026 10:22
@uroslates uroslates marked this pull request as ready for review January 20, 2026 10:36
@github-actions github-actions Bot marked this pull request as draft January 20, 2026 11:19
@uroslates uroslates marked this pull request as ready for review January 20, 2026 11:35
@uroslates uroslates changed the base branch from develop-next-major to develop January 20, 2026 12:11
@github-actions github-actions Bot marked this pull request as draft January 21, 2026 13:38
@uroslates uroslates marked this pull request as ready for review January 26, 2026 09:03
@github-actions github-actions Bot marked this pull request as draft January 26, 2026 09:03
@uroslates uroslates marked this pull request as ready for review January 26, 2026 09:03
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 26, 2026

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

rmch91
rmch91 requested changes Jan 28, 2026
View reviewed changes
Comment thread projects/core/src/cms/facade/page-meta.service.ts
protected cms: CmsService,
protected unifiedInjector: UnifiedInjector,
protected pageMetaConfig: PageMetaConfig,
@Inject(PLATFORM_ID) protected platformId: string
Copy link
Copy Markdown
Contributor

@rmch91 rmch91 Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can just like this remove the dependency from constructor.
Any change in constructor is a breaking change for customers that extend our PageMetaService.
I guess you removed it because it is not used anywhere, but it is protected, can be used in customers implementation.

In this case we should deprecate it and wait 12 months.

Copy link
Copy Markdown
Contributor Author

@uroslates uroslates Jan 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmch91 OK thanks I added it back with the depreciation comment.

@github-actions github-actions Bot marked this pull request as draft January 28, 2026 15:41
@uroslates uroslates marked this pull request as ready for review January 28, 2026 16:24
@github-actions github-actions Bot marked this pull request as draft January 28, 2026 16:24
@uroslates uroslates requested a review from rmch91 January 28, 2026 16:24
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 28, 2026

Merge Checks Failed

Please push a commit to re-trigger the build.
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@uroslates uroslates marked this pull request as ready for review January 29, 2026 08:35
rmch91
rmch91 requested changes Jan 30, 2026
View reviewed changes
Comment thread projects/core/src/cms/facade/page-meta.service.ts Outdated
protected cms: CmsService,
protected unifiedInjector: UnifiedInjector,
protected pageMetaConfig: PageMetaConfig,
// @deprecated since 4.3.8 - to be removed in 5.0
Copy link
Copy Markdown
Contributor

@rmch91 rmch91 Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, what is 4.3.8 and 5.0?
The next planned spa release is 221121.8.0

Copy link
Copy Markdown
Contributor

@rmch91 rmch91 Jan 30, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also you can tell only that will be removed in 12 months, we don't know the version which will be in 12 months yet :)

Copy link
Copy Markdown
Contributor Author

@uroslates uroslates Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied!

@github-actions github-actions Bot marked this pull request as draft January 30, 2026 17:52
@uroslates uroslates requested a review from rmch91 January 30, 2026 17:53
@uroslates uroslates marked this pull request as ready for review January 30, 2026 17:53
@github-actions github-actions Bot marked this pull request as draft February 19, 2026 07:17
@uroslates uroslates marked this pull request as ready for review February 19, 2026 07:18
@github-actions github-actions Bot marked this pull request as draft February 19, 2026 12:31
@uroslates uroslates marked this pull request as ready for review February 19, 2026 12:32
@uroslates uroslates merged commit 8dfced6 into develop Feb 19, 2026
38 checks passed
@uroslates uroslates deleted the feature/CXSPA-10923-login-page-translations-develop-next-major branch February 19, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rmch91 rmch91 rmch91 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@uroslates @rmch91