XSUAA Token getter in SecurityContext#1889
Merged
NiklasHerrmann21 merged 19 commits intomainfrom Jan 16, 2026
Merged
Conversation
Contributor
NiklasHerrmann21
commented
Nov 28, 2025
NiklasHerrmann21
commented
- changed the way the xsuaa token is retrieved by having an extension similar to the ID token retrieval to be able to perform an "getXsuaaToken" request out of the SecurityContext
- changed the way SecurityContext is build by having a wrapper of the context data that is a single threadLocal to minimize ThreadLocal Storage
- changed the way the xsuaa token is retrieved by having an extension similar to the ID token retrieval to be able to perform an "getXsuaaToken" request out of the SecurityContext - changed the way SecurityContext is build by having a wrapper of the context data that is a single threadLocal to minimize ThreadLocal Storage
- fixed test
- added javadoc and made some minor code changes
finkmanAtSap
requested changes
Dec 3, 2025
- reworked securityContext as suggested in PR comments - tests - javadoc
- made clear methods private to achieve easier backward compatibility as they are not needed to be public
- changed the token exchange in spring from a flag to a string mode to be able to support both modes - exchanging the token and only loading the token into the storage
- made the get() method in SecurityContext private to solely rely on static methods
- changed the TokenExchangeMode to an Enum value - adjusted tests - adjusted Javadoc
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kuntzed
requested changes
Dec 16, 2025
- rework extension registration logic in HybridTokenAuthenticator
- extended readme for new feature
… information into log files Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: NiklasHerrmann21 <49141792+NiklasHerrmann21@users.noreply.github.com>
…uper class Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: NiklasHerrmann21 <49141792+NiklasHerrmann21@users.noreply.github.com>
- fixed javadoc for build
- fixed Integration test
finkmanAtSap
previously requested changes
Dec 19, 2025
- MR comments, reworked README.md
|
SAP employees are expected to use their SAP-email address for commits related to their work. Our compliance check has detected usage of an email other than a SAP one by a SAP employee. Please update your pull request accordingly. If you think this is wrong or need any assistance, please contact ospo@sap.com. |
- MR comments, reworked READMEs
- added a new setter for the XSUAA token - added logic to both the authenticator and JWT Decoder to set the XSUAA token to the SecurityContext if the incoming token is already an XSUAA token
- MR comments, reworked READMEs
kuntzed
requested changes
Jan 16, 2026
- MR comments, reworked READMEs and Javadoc
kuntzed
approved these changes
Jan 16, 2026
NiklasHerrmann21
dismissed
finkmanAtSap’s stale review
Cant find missing requested change - resolved all comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.