fix(agentgateway): use CLOUD_SDK_CFG_AGW_DEFAULT_* env vars for integration tests#167
Merged
Merged
Conversation
…ration tests workflow
NicoleMGomes
approved these changes
Jun 16, 2026
Contributor
|
Ops, thank you for fixing it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Agent Gateway integration tests were reading two non-standard env vars (
TENANT_SUBDOMAIN,APPFND_CONHOS_LANDSCAPE) that didn't follow theCLOUD_SDK_CFG_*convention used by every other module. This meant the integration test workflow couldn't pick them up automatically, causing the AGW tests to always fail in CI.TENANT_SUBDOMAIN→CLOUD_SDK_CFG_AGW_DEFAULT_TENANT_SUBDOMAINin the conftest fixtureAPPFND_CONHOS_LANDSCAPE→CLOUD_SDK_CFG_AGW_DEFAULT_LANDSCAPEin the conftest, mapped back toAPPFND_CONHOS_LANDSCAPEviaos.environ.setdefault(the SDK still reads the original name internally).env_integration_tests.exampleaccordinglyCLOUD_SDK_CFG_*filter already covers the new namesTest plan
Integration Testsworkflow manually and verify AGW tests pass