Skip to content

fix(agentgateway): use CLOUD_SDK_CFG_AGW_DEFAULT_* env vars for integration tests#167

Merged
jeanscherf merged 2 commits into
mainfrom
fix/integration-tests-agw-env-vars
Jun 16, 2026
Merged

fix(agentgateway): use CLOUD_SDK_CFG_AGW_DEFAULT_* env vars for integration tests#167
jeanscherf merged 2 commits into
mainfrom
fix/integration-tests-agw-env-vars

Conversation

@jeanscherf

@jeanscherf jeanscherf commented Jun 16, 2026

Copy link
Copy Markdown
Member

Summary

The Agent Gateway integration tests were reading two non-standard env vars (TENANT_SUBDOMAIN, APPFND_CONHOS_LANDSCAPE) that didn't follow the CLOUD_SDK_CFG_* convention used by every other module. This meant the integration test workflow couldn't pick them up automatically, causing the AGW tests to always fail in CI.

  • Rename TENANT_SUBDOMAINCLOUD_SDK_CFG_AGW_DEFAULT_TENANT_SUBDOMAIN in the conftest fixture
  • Rename APPFND_CONHOS_LANDSCAPECLOUD_SDK_CFG_AGW_DEFAULT_LANDSCAPE in the conftest, mapped back to APPFND_CONHOS_LANDSCAPE via os.environ.setdefault (the SDK still reads the original name internally)
  • Update docstring and .env_integration_tests.example accordingly
  • No workflow changes needed — the existing CLOUD_SDK_CFG_* filter already covers the new names

Test plan

  • Trigger Integration Tests workflow manually and verify AGW tests pass

@jeanscherf jeanscherf requested a review from a team as a code owner June 16, 2026 16:18
@jeanscherf jeanscherf changed the title fix(ci): inject TENANT_SUBDOMAIN and APPFND_CONHOS_LANDSCAPE in integration tests workflow fix(agentgateway): use CLOUD_SDK_CFG_AGW_DEFAULT_* env vars for integration tests Jun 16, 2026
@NicoleMGomes

Copy link
Copy Markdown
Contributor

Ops, thank you for fixing it

@jeanscherf jeanscherf merged commit ab61594 into main Jun 16, 2026
10 of 11 checks passed
@jeanscherf jeanscherf deleted the fix/integration-tests-agw-env-vars branch June 16, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants