fix(deps): pin opentelemetry-exporter-otlp-proto-common to ~=1.42.1#152
Closed
jeanscherf wants to merge 1 commit into
Closed
fix(deps): pin opentelemetry-exporter-otlp-proto-common to ~=1.42.1#152jeanscherf wants to merge 1 commit into
jeanscherf wants to merge 1 commit into
Conversation
The grpc exporter (1.42.1) imports _exporter_metrics from the common package, a module introduced in 1.35.0. Without an explicit pin, pip can resolve the common package to an older incompatible version when other deps in the consumer's environment compete for it. Observed failure: a2a-agent crashing on startup with: ModuleNotFoundError: No module named 'opentelemetry.exporter.otlp.proto.common._exporter_metrics'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opentelemetry-exporter-otlp-proto-common~=1.42.1as an explicit dependency inpyproject.tomlcommon==1.42.1exactly (it imports_exporter_metricsintroduced in 1.35.0), but without declaring common directly, pip can resolve it to an older incompatible version when competing constraints exist in the consumer's environmentsap-cloud-sdk==0.18.1to0.25.0: pods were crashing withModuleNotFoundError: No module named 'opentelemetry.exporter.otlp.proto.common._exporter_metrics'Test plan
_exporter_metricsimport error after picking up the next SDK release