feat: add DestinationHttpClient to simplify calls to target systems#119
Merged
Conversation
Contributor
|
Update user-guide |
…ion in favor of get_destination
…estination user guide
61c1c68 to
13906ee
Compare
13906ee to
c77e090
Compare
NicoleMGomes
approved these changes
May 27, 2026
cassiofariasmachado
approved these changes
May 27, 2026
cassiofariasmachado
left a comment
Member
There was a problem hiding this comment.
Looks good to me. I just added a minor suggestion
e857846 to
d4f0915
Compare
vitalykumov
pushed a commit
to vitalykumov/cloud-sdk-python
that referenced
this pull request
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
DestinationHttpClient, arequestswrapper that makes calling a target system from a destination straightforward. Previously, users had to manually fetch an auth token from destination properties and build theAuthorizationheader themselves, and also manually set thesap-clientheader for OnPremise destinations. With this change:The client pre-bakes auth headers from
dest.auth_tokens(populated by the v2 API) and SAP ERP headers (sap-client,sap-language) into the session at construction time.Type of Change
How to Test
dest = client.get_destination("my-destination")http = DestinationHttpClient(dest)response = http.get("/api/resource")uv run pytest tests/destination/unit/test_destination_http_client.py -vRelated Issue
Closes #35
Checklist