chore: avoid adjust the original input obj#266
Merged
christiand93 merged 2 commits intoSAP:mainfrom Jan 27, 2026
Merged
Conversation
christiand93
requested changes
Jan 27, 2026
Member
christiand93
left a comment
christiand93
left a comment
There was a problem hiding this comment.
Hi John,
Thank you for your contribution. Please see my comment below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For long time, I was puzzled on: in our UT, when we spy on logMessage, we never get the properties _error
I thought it should be the test engine(jest, vitest) issue. but no matter what engine I use, this keeps happening.
recent days, I fork and read the cf-nodejs-logging-support code. I found the root cause.
the _error is deleted from the lastArg obj. then when the input args is checked, _error has not been inside.
When I remove this "delete" from my node_module code, my UT case pass.
I went through your whole logic, I think this delete lastArg._error should not be necessary.
would you mind I remove this line as a fix?