-
Notifications
You must be signed in to change notification settings - Fork 161
WIP: Demonstrate Hierarchy Functions #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
| on children.parent = $self; | ||
| entity Genres { | ||
| key ID : Integer; | ||
| node : Integer not null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we add the node element?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need an additional field for the association:
Association to one Genres on parent.node = parent_node;
as we discussed, following doesn't work yet:
Association to one Genres on parent.ID = parent_node;
| entity Genres { | ||
| key ID : Integer; | ||
| node : Integer not null; | ||
| parent_node : Integer default 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can get rid of the parent_node FK element with @eugene-andreev 's upcoming change.
| 22;21;Autobiography | ||
| 23;20;Essay | ||
| 24;20;Speech | ||
| ID;parent_node;name;node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the information in the ID and node column is redundant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, because I can't use the key ID in the association -> will be removed with the change of @eugene-andreev
| LimitedDescendantCount: LimitedDescendantCount, | ||
| DistanceFromRoot: DistanceFromRoot, | ||
| DrillState: DrillState, | ||
| Matched: Matched, | ||
| MatchedDescendantCount: MatchedDescendantCount, | ||
| LimitedRank: LimitedRank |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to check if we need this annotation if we don't rename anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, it looks the same in the example I got from Gwendal (no renaming), but I can't find confirmation in the documentation -> ask UI colleagues
Provides an example of an hierarchy function as
ListReportandValueHelpChanges:
LineItem parent.nameis removed fromapp/common.cds, because it leads to OData requests with$expandfor an hierarchy function which are not supported yetsap.common.CodeListaspect was removed fromGenresentity because it providesValueHelpdialog implicitly through annotation @cds.odata.valuelist. It also uses the annotation@cds.autoexpose, because of this entityGenresshould be exposed explicitly inCatalogServiceandReviewServiceaftersap.common.CodeListis removed.GenreHierarchyis temporal and will be solved by CAP Java team in the futureListReportadd tomanifest.json:PresentationVariantand root entity withPresentationVariantQualifier