Precommit #64
Merged
Precommit #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 3, 2025 22:06
added 3 commits
October 22, 2025 15:06
Allow remove-tables --all Fixed sampled choices Removed surplus df.py stuff
stefpiatek
approved these changes
Nov 3, 2025
stefpiatek
left a comment
stefpiatek
left a comment
There was a problem hiding this comment.
Very much rubber stamping with a comment
|
|
||
|
|
||
| @lru_cache(1) | ||
| def everything_factory() -> GeneratorFactory: |
There was a problem hiding this comment.
ooh nice, is there a reason that this is better than making an object here, that's imported? I presume you may want to edit the output?
Collaborator
Author
There was a problem hiding this comment.
No, could just make an object. The reason I did it like this was to try to make startup a little shorter. Startup still takes too long, though and I'm not sure this made any noticeable difference. I could do some benchmarking...
There was a problem hiding this comment.
Ah yep startup makes sense. may as well only run it when you need it 😄. Possibly worth commenting this is why you've done it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally! All the pre-commit hooks are passing, and all the tests are running on github and passing.
This was a huge job!