eventlog: add field length limits in create_event view#1519
Merged
Conversation
Truncate app_name (100), event_name (200), and details (10,000 chars) to prevent unbounded text accumulation in the database.
Contributor
Author
|
I agree that we should do this, but we should record that we trimmed |
So readers can tell the field was truncated rather than guess whether the log entry just ended early. Only applied when truncation actually happened, and only to details (app_name/event_name are identifiers).
Replace per-field truncation with a max-length dict + loop, so any field that exceeds its cap gets the same "\n[trimmed to N characters]" footer rather than only details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Truncates user-supplied fields in the
create_eventPOST endpoint before writing to the database:app_name: 100 charactersevent_name: 200 charactersdetails: 10,000 charactersRelates to SACGF/variantgrid_private#3819