Add board class similar to field but without the tuples#27
Open
freemansoft wants to merge 5 commits intoS-ecki:mainfrom
Open
Add board class similar to field but without the tuples#27freemansoft wants to merge 5 commits intoS-ecki:mainfrom
freemansoft wants to merge 5 commits intoS-ecki:mainfrom
Conversation
S-ecki
approved these changes
Dec 3, 2024
Owner
S-ecki
left a comment
S-ecki
left a comment
There was a problem hiding this comment.
This looks great! Awesome that you also include tests!
Maybe we could get rid of the Field class from before so it is clear to users which class to use + change the name in the README
Contributor
Author
|
I'm iterating so will reopen in a day or two |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding coordinate and other data structures.