feat: add localstorage support#26
Open
hilaliu wants to merge 1 commit intoRyoSogawa:mainfrom
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RyoSogawa
reviewed
Dec 13, 2023
| * callback when border position changes end | ||
| */ | ||
| onResizeEnd?: (args: ResizeCallbackArgs) => void; | ||
| useLocalstorage?: boolean; |
Owner
There was a problem hiding this comment.
@GodlessLiu
Thank you for your fantastic suggestion. ❤️
I'm a bit concerned that the key in local storage might duplicate when multiple separators are present in the project.
How about we modify it to accept the key string as a prop?
Also, could you add this feature to this story to also serve as a test for multiple separators?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add local storage to store location information for width persistence