Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cpal has (correctly) started listing the
nulldevice in 0.17. This messes up our Sink's fallback strategy since it can now land on the null device (which happily eats all samples without producing any sound.) This fixes that by filtering it out.Our microphone input has a different API, it does not have fallback. We provide a method to list all input devices which was now including null, a possible footgun if users try to implement fallback themselves. We've taken that out for now.
In my opinion automatic fallback at the Rodio layer makes no sense whatsoever. It is therefore excluded from the new output device API (working title speakers).