cargo-release setup #483
Open
cargo-release setup #483
+103
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firestar99
force-pushed
the
cargo-release
branch
from
03357aa to
64ea34c
Compare
schell
approved these changes
Dec 9, 2025
Contributor
schell
left a comment
schell
left a comment
There was a problem hiding this comment.
I appreciate you putting this together @Firestar99 🙇
Collaborator
|
|
LegNeato
reviewed
Dec 10, 2025
| cargo-run-wasm = "0.3.2" | ||
|
|
||
| [package.metadata.release] | ||
| release = false |
Collaborator
There was a problem hiding this comment.
These shouldn't be needed as we already have publish = false?
Member
Author
There was a problem hiding this comment.
cargo release doesn't respect publish = false unfortunately
(which feels like an oversight on their part?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup releases so that a simple
cargo release minor(orprerelease) in the workspace root should do it.Note that it's been quite difficult to test this configuration, like at all. Test releases (without
--execute) fail to verify the packaged crates due to using the "latest" version from crates.io instead of local changes. With the many breaking changes that requires upgrading more than one crate at once, basically all crates fail verification. Not even--no-verifyworks, since the generatedCargo.tomlwants a new feature from one of our crates, that doesn't exist onv0.9.0, so it won't even package it. Only when we actually do the full release, package verification should work, since we're actively publishing thev0.10.0(or*-alpha.0) crates and redownloading them. So for the next release, we just release immediately and hope nothing breaks 💀TLDR: Only the next release will show whether everything will just work or not, so I'll take the responsibility to do the next release and fix any issues as I encounter them.