Skip to content

Fix gaps in SPLICE implementation for instructor dashboard #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bnmnetp merged 7 commits into from
Dec 26, 2025
Merged

Fix gaps in SPLICE implementation for instructor dashboard #1089

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2de75af
Fix gaps in SPLICE implementation in instructor dashboard
sarangjo Dec 17, 2025
c679498
Don't override id with inner component in SPLICE questions
sarangjo Dec 17, 2025
3453e0a
Add splice to problem metrics dashboard
sarangjo Dec 18, 2025
9f0ed34
Merge remote-tracking branch 'upstream/main' into splice-changes
sarangjo Dec 19, 2025
f1ac0d3
Merge remote-tracking branch 'upstream/main' into splice-changes
sarangjo Dec 23, 2025
65beae0
Merge remote-tracking branch 'upstream/main' into splice-changes
sarangjo Dec 24, 2025
70846df
Respond to PR comments; remove accidental whitespace changes
sarangjo Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions bases/rsptx/web2py_server/applications/runestone/controllers/dashboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,6 +978,8 @@ def make_correct_count_table(chapters, chapter, thecourse, dburl, course):
union
(select div_id, sid, correct, percent from clickablearea_answers where course_name = '{course}')
union
(select div_id, sid, correct, percent from splice_answers where course_name = '{course}')
union
(select div_id, sid, correct, percent from dragndrop_answers where course_name = '{course}')
union
(select div_id, sid, correct, percent from unittest_answers where course_name = '{course}')
Expand Down Expand Up @@ -1179,6 +1181,22 @@ def subchapdetail():
row["correct"] = "Yes"
else:
row["correct"] = "No"
elif row["question_type"] == "splice":
# Mirror the implementation in GRADEABLE_TYPES, as `splice_answers` also has a "correct"
# column which tracks whether the answer is correct or not
isc = (
db(
(db["splice_answers"].sid == request.vars.sid)
& (db["splice_answers"].correct == "T")
& (db["splice_answers"].div_id == row["name"])
)
.select()
.first()
)
if isc:
row["correct"] = "Yes"
else:
row["correct"] = "No"
else:
row["correct"] = "NA"

Expand Down
1 change: 1 addition & 0 deletions bases/rsptx/web2py_server/applications/runestone/modules/db_dashboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ def update_metrics(self, course_name):
"dragndrop_answers",
"codelens_answers",
"webwork_answers",
"splice_answers",
]
for tbl in tbl_list:
res[tbl] = current.db(
Expand Down
6 changes: 0 additions & 6 deletions components/rsptx/build_tools/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1003,12 +1003,6 @@ def _process_single_question(
if dynamic is not None and "id" in dynamic.attrib:
idchild = dynamic.attrib["id"]
qtype = dynamic.attrib["data-component"]
# well maybe not...
else:
dynamic = el.find(".//iframe")
if dynamic is not None and "id" in dynamic.attrib:
idchild = dynamic.attrib["id"]
qtype = "splice"
if qtype == "doenet":
# rewrite the url in the dbtext to use the course name in the path
dbtext = re.sub(
Expand Down