Skip to content

Conversation

@skiadas
Copy link
Contributor

@skiadas skiadas commented Dec 17, 2025

Currently the ALLOW_INSECURE_LOGIN variable has a somewhat strange behavior. If it is set at all, the bases/rsptx/web2py_server/applications/runestone/models/db.py file uses it to determine that the access token should be set to be not secure. At the same time, the docker-compose.yml file sets this variable to have a default value, which automatically triggers the above solution.

With this proposed change:

  • The db.py file now checks to see if the variable equals the strings True or Yes (in any casing) and only then sets the access token to be not secure.
  • The variable is set in the sample.env file to be False.
  • The docker-compose.yml file still initializes this variable to True, for that default behavior when a .env file is not yet set, or the variable is not present there for some reason.

@skiadas skiadas requested a review from bnmnetp as a code owner December 17, 2025 00:56
@bnmnetp bnmnetp merged commit 1fe3551 into RunestoneInteractive:main Dec 17, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants