idea: Adjust slash command fuzzy style to match the new settings search#728
idea: Adjust slash command fuzzy style to match the new settings search#728scriptease wants to merge 1 commit intoRunMaestro:rcfrom
Conversation
…ch (except the selected slash command since it already uses the accent color as a background)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe changes enhance slash-command autocomplete highlighting by passing the theme accent color and selection state to the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thanks for the contribution @scriptease! 🎯 This looks good — the changes are clean, focused, and consistent across both desktop and mobile. Using the accent color for matched characters and dimming unmatched ones on selection is a nice touch that brings visual consistency with the settings search. Re: "maybe it is too many colors" — I think it's fine. The accent color is only applied to matched characters in the non-selected state, and on selection it falls back to font weight differentiation with opacity dimming. That's restrained and purposeful, not noisy. LGTM — approving! |
Greptile SummaryAdds fuzzy match character highlighting to the slash command autocomplete in both desktop ( Confidence Score: 5/5Safe to merge — purely additive visual enhancement with no logic, data-flow, or API changes. All findings are P2 (minor style/readability). No correctness, security, or data-integrity issues were found. The two new algorithms (fuzzyMatchWithIndices and highlightSlashCommand) are consistent with each other and with the existing fuzzyMatchWithScore filter. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant InputArea
participant search.ts
participant React
User->>InputArea: types /cmd
InputArea->>search.ts: filterSlashCommands(cmds, query, isTerminal)
Note over search.ts: fuzzyMatchWithScore per command
search.ts-->>InputArea: filtered + sorted commands
loop each matching command
InputArea->>search.ts: highlightSlashCommand(cmd, query, accentColor, isSelected)
search.ts->>search.ts: fuzzyMatchWithIndices(cmd.slice(1), query)
search.ts-->>InputArea: React.ReactNode (accent spans for matched chars)
end
InputArea->>React: render dropdown with highlighted commands
|
|
Yay 🎉 I love colors! |
I don't know maybe it it too many colors.
Summary by CodeRabbit
Release Notes