Skip to content

Conversation

Copy link

Copilot AI commented Dec 23, 2025

Conversion Plan: jsoncpp to nlohmann/json

  • Update CMakeLists.txt to use nlohmann_json instead of jsoncpp
  • Remove obsolete FindJsonCppCustom.cmake file
  • Remove jsoncpp references from samples CMake files
  • Remove COPY CMake commands from Dockerfiles
  • Update TgTypeParser.h header to use nlohmann/json
  • Convert TgTypeParser.cpp implementation to use nlohmann/json API
  • Update Api.cpp to use nlohmann/json
  • Update TgWebhookServer.h to use nlohmann/json
  • Update README.md documentation
  • Update Dockerfiles to use nlohmann-json3-dev
  • Fix JsonWrapper null checking (use is_null() instead of empty())
  • Fix getWebhookInfo parsing bug (parse whole response, not just URL field)
  • Test the build with new dependency
  • Run existing tests to ensure functionality (all 14 tests pass)
  • Address code review feedback
Original prompt

Convert source code to use nlohmann json instead of jsoncpp


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 5 commits December 23, 2025 01:43
Co-authored-by: Royna2544 <69458352+Royna2544@users.noreply.github.com>
Co-authored-by: Royna2544 <69458352+Royna2544@users.noreply.github.com>
Co-authored-by: Royna2544 <69458352+Royna2544@users.noreply.github.com>
…hecking

Co-authored-by: Royna2544 <69458352+Royna2544@users.noreply.github.com>
…t the URL field

Co-authored-by: Royna2544 <69458352+Royna2544@users.noreply.github.com>
Copilot AI changed the title [WIP] Replace jsoncpp with nlohmann json in source code Convert from jsoncpp to nlohmann/json Dec 23, 2025
Copilot AI requested a review from Royna2544 December 23, 2025 01:55
@Royna2544
Copy link
Owner

@copilot remove old findjsoncppcustom and clear its finding logic to fix that ci error

Copy link
Author

Copilot AI commented Dec 23, 2025

@copilot remove old findjsoncppcustom and clear its finding logic to fix that ci error

Removed the obsolete CMake/FindJsonCppCustom.cmake file in commit 9518576. The build now uses nlohmann_json's native CMake package configuration instead of the custom finder logic.

@Royna2544
Copy link
Owner

@copilot obviously remove the entry on cmakelists.txt

@Royna2544
Copy link
Owner

fix the workflow error, remove cmake copying

Copy link
Author

Copilot AI commented Dec 23, 2025

@copilot obviously remove the entry on cmakelists.txt

Removed all remaining jsoncpp references from CMake files in commit 418cee7. Updated samples/common_defs.cmake and samples/echobot-submodule/CMakeLists.txt to use nlohmann_json::nlohmann_json instead of JsonCpp::JsonCpp and removed the FindJsonCppCustom.cmake include.

@Royna2544
Copy link
Owner

Remove COPY Cmake Cmake from dockerfiles @copilot

Copy link
Author

Copilot AI commented Dec 23, 2025

Remove COPY Cmake Cmake from dockerfiles @copilot

Removed COPY CMake CMake from both Dockerfile and Dockerfile_test in commit 29c9883.

fix the workflow error, remove cmake copying

Removed COPY CMake CMake commands from both Dockerfiles in commit 29c9883. The CMake directory no longer exists after removing FindJsonCppCustom.cmake.

@Royna2544 Royna2544 marked this pull request as ready for review December 23, 2025 04:22
Co-authored-by: Royna2544 <69458352+Royna2544@users.noreply.github.com>
@Royna2544 Royna2544 force-pushed the copilot/convert-to-nlohmann-json branch from 29c9883 to 0b828df Compare December 23, 2025 04:23
@Royna2544 Royna2544 merged commit 14c3828 into master Dec 23, 2025
1 check passed
@Royna2544 Royna2544 deleted the copilot/convert-to-nlohmann-json branch December 23, 2025 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants