Skip to content

minor in coordchange #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RoxGamba merged 4 commits into from
Feb 7, 2026
Merged

minor in coordchange #56

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd2e51e
minor in coordchange
SimoneA96 Feb 7, 2026
7b3af00
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 7, 2026
23482f1
added also pe in output
SimoneA96 Feb 7, 2026
edf4605
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions PyART/analytic/coordschange.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,10 @@ def eob_ID_to_ADM(eob_Wave, verbose=False, PN_order=2, rotate_on_x_axis=True):
'x2' : x coordinate of puncture 2
'D' : coordinate separation between punctures
'x_offset' : offset to be added to x coordinates
'qe' : EOB coordinates (x,y)
'pe' : EOB momenta (px, py), mu-normalized
'qe_chk' : EOB coordinates (x,y), EOB->ADM->EOB
'pe_chk' : EOB momenta (px, py), mu-normalized, EOB->ADM->EOB
"""
# Get info from EOB dynamics
q = eob_Wave.pars["q"]
Expand Down Expand Up @@ -308,6 +312,8 @@ def eob_ID_to_ADM(eob_Wave, verbose=False, PN_order=2, rotate_on_x_axis=True):
x2 = -d_ADM * q / (q + 1)
x_offset = -b_par + d_ADM / (q + 1)

qe_check, pe_check = Adm2Eob(qa, pa, nu, PN_order=PN_order)

# wrap output
out = {
"q_cart": qa,
Expand All @@ -318,12 +324,13 @@ def eob_ID_to_ADM(eob_Wave, verbose=False, PN_order=2, rotate_on_x_axis=True):
"x2": x2,
"D": d_ADM,
"x_offset": x_offset,
"qe": qe,
"pe": pe,
"qe_chk": qe_check, # EOB->ADM->EOB
"pe_chk": pe_check, # EOB->ADM->EOB
}

if verbose:
# for testing
qe_check, pe_check = Adm2Eob(qa, pa, nu, PN_order=PN_order)

dashes = "-" * 50
print("{}\nPunctures\n{}".format(dashes, dashes))
print("b_par : {:.15f}".format(b_par))
Expand Down