Skip to content

Download gra#55

Merged
RoxGamba merged 9 commits intomainfrom
download-gra
Feb 6, 2026
Merged

Download gra#55
RoxGamba merged 9 commits intomainfrom
download-gra

Conversation

@RoxGamba
Copy link
Copy Markdown
Owner

Add to the Waveform_GRA class a function to automatically download simulations from scholarsphere. Additionally, fix some naming issues that were inconsistent with other classes.

Breaks retrocompatibility: we get rid of the mtdt_path option and require a certain structure of the data to be able to load it.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@RoxGamba RoxGamba marked this pull request as ready for review January 27, 2026 22:16
@RoxGamba RoxGamba requested a review from SimoneA96 January 27, 2026 22:16
@RoxGamba RoxGamba self-assigned this Feb 6, 2026
@RoxGamba RoxGamba requested review from Copilot and removed request for SimoneA96 February 6, 2026 19:03
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds first-class support for downloading and loading GRAthena++ simulations from ScholarSphere via Waveform_GRA, and updates the expected on-disk data layout (breaking change) to align with other catalog loaders.

Changes:

  • Added Waveform_GRA.download_simulation() plus supporting HTTP/HTML-scraping helpers to fetch and unpack GRA datasets.
  • Updated Waveform_GRA initialization/metadata/hlm loading to assume a structured layout (GRA_BHBH_{ID}/{res}/...) and renamed rescale to nu_rescale.
  • Added a new GRA download test and updated CI to install additional download dependencies.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 12 comments.

File Description
PyART/catalogs/gra.py Implements ScholarSphere download + adjusts metadata/hlm loading to the new directory structure.
tests/test_gra.py Adds an integration-style test validating download + basic waveform structure.
.github/workflows/tests.yml Updates CI dependencies to support the new download/test path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

RoxGamba and others added 5 commits February 6, 2026 11:09
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@RoxGamba RoxGamba merged commit 8bfeef7 into main Feb 6, 2026
2 checks passed
@RoxGamba RoxGamba deleted the download-gra branch February 6, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants