Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds first-class support for downloading and loading GRAthena++ simulations from ScholarSphere via Waveform_GRA, and updates the expected on-disk data layout (breaking change) to align with other catalog loaders.
Changes:
- Added
Waveform_GRA.download_simulation()plus supporting HTTP/HTML-scraping helpers to fetch and unpack GRA datasets. - Updated
Waveform_GRAinitialization/metadata/hlm loading to assume a structured layout (GRA_BHBH_{ID}/{res}/...) and renamedrescaletonu_rescale. - Added a new GRA download test and updated CI to install additional download dependencies.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 12 comments.
| File | Description |
|---|---|
PyART/catalogs/gra.py |
Implements ScholarSphere download + adjusts metadata/hlm loading to the new directory structure. |
tests/test_gra.py |
Adds an integration-style test validating download + basic waveform structure. |
.github/workflows/tests.yml |
Updates CI dependencies to support the new download/test path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add to the
Waveform_GRAclass a function to automatically download simulations from scholarsphere. Additionally, fix some naming issues that were inconsistent with other classes.Breaks retrocompatibility: we get rid of the
mtdt_pathoption and require a certain structure of the data to be able to load it.Type of change