fix: handle nested form submit clicks#277
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
route-engine-jsto1.20.4Testing
bunx vitest run spec/RouteEngine.form.test.jsbun run prettier src/stores/constructRenderState.js src/stores/system.store.js spec/RouteEngine.form.test.js vt/specs/form/basic.yaml -cbunx vitest rungit diff --checkdocker run --rm --user 1000:1000 -e RTGL_VT_DEBUG=true -v /home/tk/Code/yuusoft-org/route-engine:/app -w /app docker.io/han4wluc/rtgl:playwright-v1.57.0-rtgl-v1.0.10 rtgl vt screenshot --item form/basic.yaml --wait-event vt:ready --concurrency 1 --timeout 60000rtgl vt report --item form/basic.yaml --diff-threshold 0.8Note: full
bun run vt:reportcaptured 111/111 specs, but the full report failed on 14 unrelated non-form reference diffs. The targeted form report passed with 0 mismatches.