Osm processing fixes #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandu
force-pushed
the
osm-processing-fixes
branch
from
0ec3b60 to
03ebf79
Compare
edmabon
reviewed
Dec 8, 2023
Comment on lines
+172
to
+173
| else if(waySection.roadClass.getValue() > roadClass.getValue()){ | ||
| roadClass = waySection.roadClass; |
There was a problem hiding this comment.
So, higher road class number is the "lowest grade" of road, and here we are ensuring that if a segment contains multiple road classes, we use the "lowest grade"?
edmabon
reviewed
Dec 8, 2023
| int baseSegment1RoadClass = baseSegment1.getRoadClass().getValue(); | ||
| int baseSegment2RoadClass = baseSegment2.getRoadClass().getValue(); | ||
| int roadClassMergeThreshold = Way.ROAD_CLASS.ClassPrimary.getValue(); | ||
| if(baseSegment1RoadClass != baseSegment2RoadClass && (baseSegment1RoadClass <= roadClassMergeThreshold || baseSegment2RoadClass <= roadClassMergeThreshold)) |
There was a problem hiding this comment.
What if both are below the threshold? I think in this case they should be mergeable, but I don't think they are with this logic.
There was a problem hiding this comment.
I'd suggest:
if(baseSegment1RoadClass != baseSegment2RoadClass) {
if ((baseSegment1RoadClass < roadClassMergeThreshold && baseSegment2RoadClass >= roadClassMergeThreshold) ||
(baseSegment2RoadClass < roadClassMergeThreshold && baseSegment1RoadClass >= roadClassMergeThreshold)) {
return false;
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits