Skip to content

Optimize the config saving, by using "Bulk Saving" method instead. #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AALUND13 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Optimize the config saving, by using "Bulk Saving" method instead. #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c37f9d
Optimize config loading/saving
AALUND13 Feb 22, 2026
6ebf5df
Optimize "Toggle Cards" menu
AALUND13 Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions UnboundLib/Unbound.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ public Unbound()
{
// Add UNBOUND text to the main menu screen
bool firstTime = true;
config.SaveOnConfigSet = false;

On.MainMenuHandler.Awake += (orig, self) =>
{
Expand Down Expand Up @@ -336,6 +337,12 @@ private void Start()

// sync modded clients
networkEvents.OnJoinedRoomEvent += SyncModClients.RequestSync;

this.ExecuteAfterSeconds(1, () =>
{
config.Save();
config.SaveOnConfigSet = true;
});
}

private void Update()
Expand Down
10 changes: 10 additions & 0 deletions UnboundLib/Utils/CardManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,12 @@ public static CardInfo GetCardInfoWithName(string cardName)

public static void EnableCards(CardInfo[] cardInfos, bool saved = true)
{
Unbound.config.SaveOnConfigSet = false;
foreach (var card in cardInfos)
{
EnableCard(card, saved);
}
Unbound.config.SaveOnConfigSet = true;
}

public static void EnableCard(CardInfo cardInfo, bool saved = true)
Expand Down Expand Up @@ -154,10 +156,12 @@ public static void EnableCard(CardInfo cardInfo, bool saved = true)

public static void DisableCards(CardInfo[] cardInfos, bool saved = true)
{
Unbound.config.SaveOnConfigSet = false;
foreach (var card in cardInfos)
{
DisableCard(card, saved);
}
Unbound.config.SaveOnConfigSet = true;
}

public static void DisableCard(CardInfo cardInfo, bool saved = true)
Expand Down Expand Up @@ -186,19 +190,25 @@ public static void DisableCard(CardInfo cardInfo, bool saved = true)
public static void EnableCategory(string categoryName)
{
if (categoryBools.ContainsKey(categoryName)) categoryBools[categoryName].Value = true;

Unbound.config.SaveOnConfigSet = false;
foreach (string cardname in GetCardsInCategory(categoryName))
{
EnableCard(cards[cardname].cardInfo, true);
}
Unbound.config.SaveOnConfigSet = true;
}

public static void DisableCategory(string categoryName)
{
if (categoryBools.ContainsKey(categoryName)) categoryBools[categoryName].Value = false;

Unbound.config.SaveOnConfigSet = false;
foreach (string cardname in GetCardsInCategory(categoryName))
{
DisableCard(cards[cardname].cardInfo, true);
}
Unbound.config.SaveOnConfigSet = true;
}

public static bool IsCardActive(CardInfo card)
Expand Down
6 changes: 6 additions & 0 deletions UnboundLib/Utils/UI/ToggleCardsMenuHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,7 @@ private void Start()
toggledAll = !toggledAll;

var cardsInCategory = CardManager.GetCardsInCategory(currentCategory);
Unbound.config.SaveOnConfigSet = false;
if (toggledAll)
{
var objectsInCategory = GetCardObjects(cardsInCategory);
Expand All @@ -139,6 +140,7 @@ private void Start()
cardObjs[cardObject].Invoke();
}
}
Unbound.config.SaveOnConfigSet = true;
});

// get and set info button
Expand Down Expand Up @@ -336,22 +338,26 @@ private void DisableCards()
private void DisableCardsInCategory(string category)
{
if (!cardObjectsInCategory.ContainsKey(category)) return;
Unbound.config.SaveOnConfigSet = false;
foreach (GameObject cardObject in cardObjectsInCategory[category])
{
cardObject.SetActive(false);
}
Unbound.config.SaveOnConfigSet = true;
}

private IEnumerator EnableCardsInCategory(string category)
{
if (!cardObjectsInCategory.ContainsKey(category)) yield break;
Unbound.config.SaveOnConfigSet = false;
foreach (GameObject cardObject in cardObjectsInCategory[category])
{
var active = ActiveOnSearch(cardObject.name);
cardObject.gameObject.SetActive(active);
UpdateVisualsCardObj(cardObject);
yield return new WaitForEndOfFrame();
}
Unbound.config.SaveOnConfigSet = true;
}

internal static Color uncommonColor = new Color(0, 0.5f, 1, 1);
Expand Down