Issue #5483 parse address line#5489
Open
bschmalhofer wants to merge 7 commits intorel-11_1from
Open
Conversation
show that whitespace is normalized
assuming that 'map' is beautiful Also, in the sample code of the POD, change the unmotivated 'qeber' to 'weber'.
replacing the private method _MailAddressParse() added a couple of test cases
Start using `Path::Class::file->slurp()` for reading in sample files. Better grouping of tests in subtests. One subtest for each tested method. Add test cases for when the address does not contain an '@'. Add test cases for the planned parameter 'AddressObject' in GetEmailAddress() Not adding a test case with quoted-pair as Mail::Address gives a strange result.
just to make it more clear which test cases belong together
Keep the logic where an empty list is returned when the address does not contain an '@'. Test cases for GetEmailAddress() where an address object were already present. Document that using ParseAddressLine() is recommended. Call ParseAddressLine() instead of SplitAddressLine() in the case where only GetEmailAddress() is called. In these case pass the instance of Mail::Address to GetEmailAddress(). Use $AddressObject->format in the case where the stringified address object is needed.
use that variant in MIMEBase.pm add basic test cases
bschmalhofer
force-pushed
the
issue-#5483-parse_address_line
branch
from
9c4869b to
73c94e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.