Issue #5390: Replaced previous sorting with SQL order by enhancement.#5404
Open
stefanhaerter wants to merge 3 commits intorel-11_1from
Open
Issue #5390: Replaced previous sorting with SQL order by enhancement.#5404stefanhaerter wants to merge 3 commits intorel-11_1from
stefanhaerter wants to merge 3 commits intorel-11_1from
Conversation
stefanhaerter
force-pushed
the
issue-#5390-sql_sort
branch
from
0d8ce2a to
2270e53
Compare
|
|
||
| # ensure that body statements are listed at the very end of matching conditions | ||
| # for performance reasons | ||
| . ' CASE' |
Contributor
There was a problem hiding this comment.
This look like valid syntax for PostgreSQL, wondering whether it is documented that only MariaDB, MySQL and PostgreSQL are supported for OTOBO databases.
Contributor
Author
There was a problem hiding this comment.
As far as I saw, Oracle supports this as well.
| . ' FROM postmaster_filter' | ||
| . ' WHERE f_name = ?' | ||
| . ' ORDER BY is_body, f_key, f_value', | ||
| SQL => <<~"POSTMASTER_SELECT", |
Contributor
There was a problem hiding this comment.
Congrats on the first indented heredoc in OTOBO!
stefanhaerter
force-pushed
the
issue-#5390-sql_sort
branch
from
2270e53 to
ccfbd34
Compare
stefanhaerter
force-pushed
the
issue-#5390-sql_sort
branch
from
ccfbd34 to
ed395a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #5390
replaces #5391