Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new “UGREEN” platform preset (UGOS Pro / Container Manager) to the configurator so users get sensible default mount paths and guidance when generating configs.
Changes:
- Added
ugreen.jsonplatform preset with UGREEN-specific default paths, hint text, and a/volumeroot pattern. - Inserted
ugreeninto the platform manifest ordering (index.json) betweentruenasandlinux. - Updated the E2E dropdown-order assertion to include the new platform.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| configurator/public/platforms/ugreen.json | Introduces the UGREEN preset defaults (paths, hint, rootPattern). |
| configurator/public/platforms/index.json | Adds ugreen to the platform dropdown ordering/manifest. |
| configurator/e2e/configurator.spec.ts | Updates the expected platform dropdown options list to include ugreen. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
decriptor
force-pushed
the
shaw/add-ugreen-platform
branch
from
d8e8ab4 to
3e245a6
Compare
Adds UGREEN (UGOS Pro / Container Manager) to the platform dropdown
with Synology-style /volume1/... defaults.
Defaults:
- roon: /volume1/docker/roon (matches the Marius Hosting / community
Docker convention used across UGREEN guides)
- music: /volume1/Music (capital M — the auto-created share UGOS Pro
ships with by default; paths are case-sensitive)
- backup: /volume1/roon-backups (mirrors the Synology default; UGREEN
community has no standard backup convention)
rootPattern is `^/volume` (rather than `^/volume\d+/`) so /volumeUSB1/...
external-drive paths don't trigger a false-positive warning. Hint calls
out the network_mode: host requirement since bridged mode breaks Roon's
mDNS/SSDP discovery — the most common UGREEN-specific support topic in
the Roon Community.
No userOverride: UGREEN Container Manager honors the image's default
user, unlike TrueNAS Apps' UID 568 default.
Position in index.json: between truenas and linux, so existing platform
ordering is preserved.
Closes #16.
decriptor
force-pushed
the
shaw/add-ugreen-platform
branch
from
3e245a6 to
6d646e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds UGREEN (UGOS Pro / Container Manager) to the configurator's platform dropdown with researched, community-validated defaults.
Closes #16.
Defaults
roon/volume1/docker/roon/volume1/docker/<app>as the de facto layoutmusic/volume1/MusicMusicshared folder (capital M) on initial setup. Linux underneath is case-sensitive, so capitalization mattersbackup/volume1/roon-backupsprefix/volume1/rootPattern^/volume^/volume\d+/so/volumeUSB1/usbshare/...external-drive paths don't false-positive a warninguserOverride0:0workaround neededHint copy
The
network_mode: hostcallout is deliberate: it's the single most common UGREEN-specific support topic in the Roon Community for Docker setups (bridged mode silently breaks mDNS/SSDP).Position in dropdown
index.jsonorder:qnap, synology, unraid, truenas, ugreen, linux, custom— appended betweentruenasand thelinux/customtail so existing platform ordering is preserved.Sources backing the choices
/volume1storage location/volume1/docker/<app>convention)Musicshare, capitalized)Test plan
npm run typecheckcleannpm test— 121/121 (platforms tests auto-discover the new JSON and validate it againstschema.json)npm run test:e2e— 23/23 (dropdown-order test updated to includeugreen)