feat: add weave semantic merge driver integration for worktrees#11711
Draft
roomote[bot] wants to merge 1 commit intomainfrom
Draft
feat: add weave semantic merge driver integration for worktrees#11711roomote[bot] wants to merge 1 commit intomainfrom
roomote[bot] wants to merge 1 commit intomainfrom
Conversation
|
This is really well done. The One note: the supported extensions list should stay in sync with what sem-core actually supports, which is currently 13 languages. You can pull the full list from Happy to review in more detail or help with the MCP coordination tools follow-up when you get there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #11710
Description
This PR attempts to address Issue #11710 by adding integration for the weave semantic merge driver into Roo Code's worktree infrastructure. As discussed in the issue, this focuses on the merge driver configuration first (priority item), with MCP coordination tools as a follow-up.
What this adds:
WeaveMergeDriverService(packages/core/src/worktree/weave-merge-driver.ts): Platform-agnostic service that:weaveis installed on PATH.gitconfigand.gitattributesmerge.weave.driverin local git config + file patterns in.gitattributes)Webview message types for
getWeaveMergeDriverStatus,configureWeaveMergeDriver, andunconfigureWeaveMergeDriverMessage handler integration wired into the existing worktree message handling flow
22 tests covering detection, configuration, unconfiguration, deduplication, and edge cases
Design decisions:
.gitattributeswithout duplicating entriesexecFile(notexecwith shell interpolation) for git config commands to handle values with spaces safelyTest Procedure
cd packages/core && npx vitest run src/worktree/__tests__/weave-merge-driver.spec.tsPre-Submission Checklist
Documentation Updates
Additional Notes
Feedback and guidance are welcome. The MCP coordination tools (
weave-mcp --stdio) integration is planned as a follow-up.Interactively review PR in Roo Code Cloud