fix(release): raise Node heap to avoid macOS build OOM#41
Merged
Conversation
The v0.11.2 release run (25514990847) failed on macos-latest with "FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory" while electron-vite was bundling the renderer. The Monaco editor chunk (~6 MB) plus Vite 7's larger in-memory graph push past Node's default 2 GB limit on the macOS runner. Set NODE_OPTIONS=--max-old-space-size=8192 at the job level so all three platforms run with the same heap cap. 8 GB is comfortably under the macos-latest runner's 14 GB and matches what other Electron/Monaco projects use. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Release run 25514990847 for v0.11.2 failed on
macos-latestduringelectron-vite build:Renderer bundle includes the Monaco editor chunk (~6 MB) and Vite 7 keeps a larger in-memory graph than v6, so the build now exceeds Node's default 2 GB old-space heap on the macOS runner. Linux + Windows happened to squeak under the limit but the same risk applies to them.
Fix
Set
NODE_OPTIONS=--max-old-space-size=8192at the build job level. 8 GB is comfortably under the macos-latest runner's 14 GB, and applies uniformly to all three platforms.Next step
Once merged, re-cut the v0.11.2 tag (or push a v0.11.3) so the macOS
.dmgactually publishes.